Skip to content

feat: Ruleset support#25

Merged
TylerMizuyabu merged 72 commits into
mainfrom
ruleset-support
Mar 14, 2024
Merged

feat: Ruleset support#25
TylerMizuyabu merged 72 commits into
mainfrom
ruleset-support

Conversation

@TylerMizuyabu

@TylerMizuyabu TylerMizuyabu commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

Adds the following features to support rulesets:

  1. A rulesets field in the organization module to make organization wide rulesets
  2. A rulesets field in the repository modules to make rulesets at the repository level
  3. A few variables to add predefined rulesets to an organization that protect the default branch of all repos in the organization:
    1. A ruleset that prevents deletion, force pushes, and requires a PR to merge commits into the branch
    2. A ruleset that requires a minimum number of approvals from reviewers that aren't the code submitter
    3. A ruleset to dismiss stale reviews
    4. A ruleset that requires commits to have verified signatures

@TylerMizuyabu TylerMizuyabu linked an issue Mar 14, 2024 that may be closed by this pull request
bzarboni1
bzarboni1 previously approved these changes Mar 14, 2024

@bzarboni1 bzarboni1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one question / suggestion

Comment thread modules/repository_set/repositories.tf Outdated
Not using the correct local variable

Co-authored-by: Ben Zarboni <99673202+bzarboni1@users.noreply.github.com>
Signed-off-by: TylerMizuyabu <tyler.mizuyabu@focisolutions.com>
bzarboni1
bzarboni1 previously approved these changes Mar 14, 2024
blastdan
blastdan previously approved these changes Mar 14, 2024
@TylerMizuyabu TylerMizuyabu dismissed stale reviews from blastdan and bzarboni1 via 76febc3 March 14, 2024 18:30
@TylerMizuyabu TylerMizuyabu merged commit 29f3544 into main Mar 14, 2024
@TylerMizuyabu TylerMizuyabu deleted the ruleset-support branch March 14, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Ruleset Support

3 participants